Repository navigation
Build the clang-cl check with Visual Studio's clang-cl - #480
Merged
Merged
Conversation
The runner's own LLVM comes first on PATH, and once its image moved to MSVC 14.52 the STL stopped the build with STL1000, which wants Clang 22, while that LLVM was Clang 20. The job now puts the clang-cl Visual Studio installs with its STL ahead of it, and stops with a clear error when Visual Studio has none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main run on the merge of #476 failed in Check MSVC builds with clang-cl before compiling anything: the Windows runner image moved to MSVC 14.52, whose STL stops with STL1000 unless the compiler is Clang 22 or newer, and the runner's own LLVM, first on PATH, is Clang 20.
The job now puts the clang-cl Visual Studio installs with its STL ahead of it, and stops with a clear error when Visual Studio has none. A dispatched main run on this branch built and passed the runtime tests with it (clang 22.1.3): https://github.com/openfl/libhxcpp/actions/runs/44755934820
This blocks 6.0.0-rc.3, whose release workflow needs CI to pass on the release commit.