Skip to content

[FSSDK-12094] Fix Python holdout implementation which related to FSC failures - #471

Merged
Esra Kartal (esrakartalOpt) merged 16 commits into
masterfrom
esra/FSSDK-12094_fix_FSC_tests
Dec 19, 2025
Merged

Esra Kartal (esrakartalOpt) merged 16 commits into
masterfrom
esra/FSSDK-12094_fix_FSC_tests

Conversation

@esrakartalOpt

@esrakartalOpt Esra Kartal (esrakartalOpt) commented Dec 10, 2025 •

Copy link
Copy Markdown
Contributor

Summary

  • Fixed Python Holdout implementation

Test plan

Issues

@esrakartalOpt Esra Kartal (esrakartalOpt) changed the title [FSSDK-12094] Fix Ruby holdout implementation which related to FSC failures [FSSDK-12094] Fix Python holdout implementation which related to FSC failures Dec 11, 2025
@esrakartalOpt
Esra Kartal (esrakartalOpt) marked this pull request as ready for review December 16, 2025 18:23

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We need to figure out, how can we reuse Variation instead VariationDict

Comment thread .github/workflows/python.yml Resolved
Comment thread optimizely/bucketer.py Resolved

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment thread optimizely/entities.py Resolved
Comment thread optimizely/project_config.py Resolved
@esrakartalOpt
Esra Kartal (esrakartalOpt) merged commit 1f87f42 into master Dec 19, 2025
14 checks passed
@esrakartalOpt
Esra Kartal (esrakartalOpt) deleted the esra/FSSDK-12094_fix_FSC_tests branch December 19, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants