Repository navigation
Conversation
Rom1-B
force-pushed
the
support_47696
branch
2 times, most recently
from
November 18, 2026 10:15
4da3346 to
b786618
Compare
Rom1-B
requested review from
a team,
Herafia,
Mary-Clb and
jdurand-teclib
and removed request for
a team
November 18, 2026 10:17
Rom1-B
force-pushed
the
support_47696
branch
from
November 19, 2026 15:19
b786618 to
d771e6a
Compare
| $column = $DB->quoteName($table . '_' . $field) . '.' . $DB->quoteName($field); | ||
| $number_predicate = static function (string $operator, string $value) use ($DB, $column): string { | ||
| $value = str_replace(',', '.', trim($value)); | ||
| if (!is_numeric($value) || abs((float) $value) >= 1e35) { |
Contributor
There was a problem hiding this comment.
The value filter doesn't seem to work.
I tried the following on your branch and got a 1264 SQL query warning:
- Create a tab block for computer
- Create a number field
- fill the field with 1e40 as value
- Make a search in computer list with the field < 2000
- Got a Warning
It shouldn't happen, as you are filtering values above 1e35, but maybe we do not make that check ?
Herafia
approved these changes
Nov 20, 2026
jdurand-teclib
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
is/is notreturned nothing for values of 1000 or more, because values were cast toDECIMAL(10,7)which caps them at 999.9999999.<,>,<=and>=compared values as text, so< 2000excluded 999 but included 12345.is notand negated criteria excluded items whose block was never saved.1000equals1000.0, comma accepted as decimal separator), negated criteria include items without value, a non numeric searched value matches nothing instead of raising a SQL warning, andis 0matches items without value like core does.Screenshots (if appropriate):