Repository navigation
fix(deps): update OpenTelemetry instrumentation and repair exemplar tests - #2690
Draft
zeitlinger wants to merge 1 commit into
Draft
zeitlinger wants to merge 1 commit into
zeitlinger wants to merge 1 commit into
Conversation
…ests Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am replacing #2602 with the dependency update and its test repair.
The updated OpenTelemetry SDK returns a no-op tracer when no span processor is registered, so the sampled exemplar test no longer records an exemplar. I added a SimpleSpanProcessor backed by InMemorySpanExporter to both ExemplarTest tracer providers, preserving their assertions, and updated otel.instrumentation.version to 2.33.1-alpha.
I ran mise run lint:fix successfully. Both ExemplarTest tests passed, and the OpenTelemetry exporter module and its dependencies built successfully with ./mvnw -pl prometheus-metrics-exporter-opentelemetry -am install -DskipTests -Dcoverage.skip=true. The full mise run build reached it-exporter-test but failed because this environment has no Docker runtime for Testcontainers; full integration coverage remains for CI.