[xuantengh]

This PR makes __name__ and __file__, as a proxy for _LazyModule.__spec__. That says, reading & writing both will be directly forwarded to _LazyModule.__spec__, which will NOT trigger the lazy loading.

• Issue: inspect.getframeinfo forces all lazy modules to be loaded #139669

[python-cla-bot]

All commit authors signed the Contributor License Agreement.

[read-the-docs-community]

Documentation build overview

📚 cpython-previews | 🛠️ Build #35907799 | 📁 Comparing c8188dc against main (b18b6a4)

  🔍 Preview build  

465 files changed · + 14 added · ± 450 modified · - 1 deleted

+ Added

• builtins/constants.html
• builtins/exceptions.html
• builtins/functions.html
• builtins/index.html
• builtins/stdtypes.html
• builtins/threadsafety.html
• builtins/time-complexity.html
• c-api/pyexpat.html
• library/asyncio-threading.html
• library/asyncio-tools.html
• and 4 more...

± Modified

• glossary.html
• index.html
• license.html
• py-modindex.html
• _static/tachyon-example-heatmap.html
• c-api/arg.html
• c-api/bool.html
• c-api/buffer.html
• c-api/bytearray.html
• c-api/bytes.html
• and 440 more...

- Deleted

• library/asyncio-policy.html

[github-actions]

This PR is stale because it has been open for 90 days with no activity.

[kushaldas]

This breaks the pre-existing promise:

cpython/Lib/test/test_importlib/test_lazy.py

Line 110 in 1d64195

def test_mutated_preexisting_attr(self):

that changing the attribute should persist.

For example if you add the following in Lib/test/test_importlib/test_lazy.py , this passes in the current implementation but fails after applying the patch.

def test_mutated_name_survives_loading(self):
    module = self.new_module()
    module.__name__ = 'bogus'

    # Reading __name__ no longer triggers loading.
    self.assertEqual(module.__name__, 'bogus')

    # Accessing attr executes TestingImporter's source, which assigns
    # __name__ = 'changed'. The earlier user assignment should survive.
    self.assertEqual(module.attr, 42)
    self.assertEqual(module.__name__, 'bogus'

The __name__ assignment should survive the loading.

[bedevere-app]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[xuantengh]

I have made the requested changes; please review again

[bedevere-app]

Thanks for making the requested changes!

@kushaldas: please review the changes made to this pull request.