Skip to content

Add toasts on failures in the downloader - #3261

Open
fire-light42 wants to merge 3 commits into
masterfrom
fix-download-toasts
Open

fire-light42 wants to merge 3 commits into
masterfrom
fix-download-toasts

Conversation

@fire-light42

Copy link
Copy Markdown
Collaborator

Downloading in CloudStream is suffering from quiet failures. This pull request makes it obvious to the user what fails and what to do.

I also fixed an issue where delete() would throw an exception, which created an invalid downloading state. The entire downloading system should honestly be reworked.

This is mergable but I did observe one issue. Toasts can be played multiple times when the downloader tries multiple links. I found no good solution to this issue. I therefore made this a draft. A throwable field could possibly be added to DownloadStatus.

What do you think @LagradOst ?

@fire-light42 fire-light42 added the Tricky merge A pull request that is difficult to merge as is. It requires significant refactors. label Nov 1, 2026
@fire-light42
fire-light42 marked this pull request as ready for review November 20, 2026 22:55
@fire-light42 fire-light42 added Looks good Nothing looks obviously wrong in this pull request. It just needs to be tested and reviewed. and removed Tricky merge A pull request that is difficult to merge as is. It requires significant refactors. labels Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Looks good Nothing looks obviously wrong in this pull request. It just needs to be tested and reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant