Skip to content

Compose Homepage UI - #3337

Draft
LagradOst wants to merge 1 commit into
recloudstream:masterfrom
LagradOst:homev2
Draft

LagradOst wants to merge 1 commit into
recloudstream:masterfrom
LagradOst:homev2

Conversation

@LagradOst

Copy link
Copy Markdown
Contributor

Initial proof of concept for a new homepage UI in compose, including minor UI changes to other screens as well. The current UI is only for TV, and lacks several features.

TODO:

  • Phone UI
  • Load cache
  • Some nav stuff for TV
  • Checkbox for hero/bookmarks/resume
  • Checkbox and reorder of api rows

Technical details:
For testing I used a hardcoded TMDB plugin, and therefore also updated it slightly.

The main challenges this PR solves for future PRs is the database system key-value store. Viewmodels should be isolated from the android context, but still need to listen for changes on the DatastoreHelper account. This is quite tricky as propagating e.g. Event<T> to a viewmodel without the direct handle to Event<T> is very convoluted. Therefore, I choose to instead rely entirely on the preference system. Now we should have an easy way to access keys, and listen to changes, even for an account. However, due to the old storage solutions, the values are stored weird (json for string causing "x"->""x""😢)

Also note that e.g. resume watching is not in the shared context, so it is by default not cross platform.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant