Repository navigation
Compose Homepage UI - #3337
Draft
LagradOst wants to merge 1 commit into
Draft
Compose Homepage UI#3337LagradOst wants to merge 1 commit into
LagradOst wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial proof of concept for a new homepage UI in compose, including minor UI changes to other screens as well. The current UI is only for TV, and lacks several features.
TODO:
Technical details:
For testing I used a hardcoded TMDB plugin, and therefore also updated it slightly.
The main challenges this PR solves for future PRs is the database system key-value store. Viewmodels should be isolated from the android context, but still need to listen for changes on the DatastoreHelper account. This is quite tricky as propagating e.g.
Event<T>to a viewmodel without the direct handle toEvent<T>is very convoluted. Therefore, I choose to instead rely entirely on the preference system. Now we should have an easy way to access keys, and listen to changes, even for an account. However, due to the old storage solutions, the values are stored weird (json for string causing "x"->""x""😢)Also note that e.g. resume watching is not in the shared context, so it is by default not cross platform.