Skip to content

fix: 4.18 - Encode the link to the metrics dashboard - #328

Merged
keithchong merged 2 commits into
redhat-developer:release-4.18from
keithchong:release-4.18-fix-EncodeLinkToMetrics-11491
Nov 17, 2026
Merged

keithchong merged 2 commits into
redhat-developer:release-4.18from
keithchong:release-4.18-fix-EncodeLinkToMetrics-11491

Conversation

@keithchong

Copy link
Copy Markdown
Collaborator

Similar to #327 but for the release-4.18 branch

Also includes #308

Signed-off-by: Keith Chong <kykchong@redhat.com>
@openshift-ci
openshift-ci Bot requested review from aali309 and wtam2018 November 13, 2026 23:05
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5a01082a-2fca-4bea-870d-2571e5e4617a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

@codecov-commenter

codecov-commenter commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 12.20%. Comparing base (175b2c4) to head (5e256aa).
⚠️ Report is 8 commits behind head on release-4.18.

Files with missing lines Patch % Lines
...iew/operational-metrics/OperationalMetricsCard.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-4.18     #328      +/-   ##
================================================
- Coverage         12.76%   12.20%   -0.56%     
================================================
  Files               172      204      +32     
  Lines              6839     7841    +1002     
  Branches           2247     2672     +425     
================================================
+ Hits                873      957      +84     
- Misses             5965     6883     +918     
  Partials              1        1              
Flag Coverage Δ
unit-tests 12.20% <0.00%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aali309 aali309 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Keith, just a question.

Comment thread plugin-metadata.ts Resolved
Signed-off-by: Keith Chong <kykchong@redhat.com>

@aali309 aali309 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Test failure (pipelinerun start failure due to PipelineRun creation temporarily disabled) is unrelated to the changes!

@keithchong
keithchong merged commit 48e43ba into redhat-developer:release-4.18 Nov 17, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants