Repository navigation
Conversation
Signed-off-by: Atif Ali <atali@redhat.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 11.30% 15.53% +4.23%
==========================================
Files 169 234 +65
Lines 6679 8516 +1837
Branches 2235 2811 +576
==========================================
+ Hits 755 1323 +568
- Misses 5923 7191 +1268
- Partials 1 2 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| try { | ||
| return new SemVer(openshiftVersion).compare('4.18.99999999') >= 0; | ||
| } catch { | ||
| return true; |
There was a problem hiding this comment.
If there is an exception/error, we should not enable the topology view?
There was a problem hiding this comment.
Good call — updated. We disable Topology when the version is missing or SemVer throws.
| /** Enable Topology for OCP >= 4.19; fail open when version is unknown (namespace users often cannot read ClusterVersion). */ | ||
| export const shouldEnableGitOpsTopology = (openshiftVersion?: string | null): boolean => { | ||
| if (!openshiftVersion) { | ||
| return true; |
There was a problem hiding this comment.
If there is no openshift version or it's undefined, then we should disable the topology view?
There was a problem hiding this comment.
Thanks, updated to return false when the version is missing/undefined.
Signed-off-by: Atif Ali <atali@redhat.com>
see: GITOPS-12070