Skip to content

fix: bound sync-window duration parsing to prevent ReDoS to release-4.18 branch - #333

Merged
keithchong merged 3 commits into
redhat-developer:release-4.18from
aali309:GITOPS-12037-4.18
Nov 18, 2026
Merged

keithchong merged 3 commits into
redhat-developer:release-4.18from
aali309:GITOPS-12037-4.18

Conversation

@aali309

@aali309 aali309 commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

cherry-pick of: #329

Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cfad9786-e945-4363-a2bc-2a7a30ed2925

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

@codecov-commenter

codecov-commenter commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.19355% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.71%. Comparing base (175b2c4) to head (a504e34).
⚠️ Report is 13 commits behind head on release-4.18.

Files with missing lines Patch % Lines
...itops/components/project/ProjectSyncWindowsTab.tsx 0.00% 14 Missing ⚠️
...itops/components/project/parseDurationToMinutes.ts 95.83% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-4.18     #333      +/-   ##
================================================
- Coverage         12.76%   12.71%   -0.06%     
================================================
  Files               172      205      +33     
  Lines              6839     7889    +1050     
  Branches           2247     2686     +439     
================================================
+ Hits                873     1003     +130     
- Misses             5965     6885     +920     
  Partials              1        1              
Flag Coverage Δ
unit-tests 12.71% <74.19%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Atif Ali <atali@redhat.com>

@keithchong keithchong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for release-4.18

@keithchong
keithchong merged commit 2db8b33 into redhat-developer:release-4.18 Nov 18, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants