Skip to content

fix(rspack): migrate HTTP cache and upgrade to 2.3.3 - #524

Closed
SoonIter wants to merge 1 commit into
mainfrom
fix-http-import-rspack-upgrade
Closed

SoonIter wants to merge 1 commit into
mainfrom
fix-http-import-rspack-upgrade

Conversation

@SoonIter

Copy link
Copy Markdown
Member

The HTTP import example fails with Invalid HTTP lockfile entry for entries: missing integrity after Rspack #16656, which aligns HTTP lockfiles and cache filenames with webpack.

Migrate the committed lockfile to flat URL entries with contentType, remove transient validators, and rename the cached resource to the new format while preserving its bytes and integrity. Upgrade all directly declared @rspack/core and @rspack/cli dependencies from 2.2.8 to 2.3.3, which includes the format change, and refresh the pnpm lockfile.

Validation:

  • Reproduced the original error with published Rspack 2.3.3 before migration; the migrated example builds and its dev server serves the compiled app.
  • Frozen offline build passed with a throwing HTTP client: zero requests, unchanged lockfile, and the emitted bundle renders the answer to the universe is 42.
  • pnpm install --frozen-lockfile --ignore-scripts, pnpm build:rspack:eco-ci, and pnpm test:rspack:eco-ci passed.
  • Rsdoctor's Rspack example and the Rstest Rspack adapter / Module Federation examples build; the Rspack adapter test passes.
  • Formatting checks for changed manifests and git diff --check passed.

Local validation used macOS arm64 and Node.js 24.20.0. Full repository CI and a new ecosystem CI run remain to be verified.

Copilot AI balanced review requested due to automatic review settings November 17, 2026 09:17
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-17T09:17:35.343110Z
We couldn’t complete this review. Comment @codex review to try again.
6f4bd8e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chenjiahan

Copy link
Copy Markdown
Member

#527

@chenjiahan chenjiahan closed this Nov 19, 2026
@chenjiahan
chenjiahan deleted the fix-http-import-rspack-upgrade branch November 19, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants