Skip to content

chore(deps): centralize Rstack versions with pnpm catalogs - #525

Closed
SoonIter wants to merge 2 commits into
mainfrom
chore/pnpm-catalog-20261118-124125
Closed

SoonIter wants to merge 2 commits into
mainfrom
chore/pnpm-catalog-20261118-124125

Conversation

@SoonIter

@SoonIter SoonIter commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Centralize only Rstack products and official plugins for shared upgrades: 42 packages, 47 catalog entries, and 519 references. This covers @rspack/*, @rsbuild/*, @rslib/*, @rspress/*, @rstest/*, @rsdoctor/*, rstack, and verified rstackjs-maintained Rspack and Storybook integrations listed in the README.

All other dependencies keep their original direct version strings, including React, Vue, TypeScript, SWC, Module Federation, testing libraries, and utilities. Two small named catalogs preserve existing Rstack range/version differences. Effective dependency ranges and every locked resolution are unchanged; peer contracts, workspace links, and npm aliases are preserved. Document catalog maintenance and standalone example setup; existing Taze configuration remains compatible.

Validation for this revision (Node 24.16.0, pnpm 10.34.1):

  • Rstack-only scope checks, exact baseline range/lockfile comparison, frozen install, lint/format, and Taze discovery passed.
  • Representative builds covered all six projects; full Rsbuild/Rslib/Rspress/Rsdoctor/Rstest builds and Rspack builds excluding the two Next.js examples passed. Rspack/Rstest/Rslib tests passed.
  • The two Next.js examples were not rerun in this revision. Their SecurityFatalError was previously reproduced on the unchanged baseline.

Copilot AI balanced review requested due to automatic review settings November 18, 2026 04:51
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-18T04:51:36.814296Z
We couldn’t complete this review. Comment @codex review to try again.
9ec911d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@SoonIter SoonIter changed the title chore(deps): centralize versions with pnpm catalogs chore(deps): centralize Rstack versions with pnpm catalogs Nov 18, 2026

@chenjiahan chenjiahan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change may break the Clone single example usage

@SoonIter SoonIter closed this Nov 18, 2026
@SoonIter

Copy link
Copy Markdown
Member Author

Thanks for catching this, @chenjiahan. I overlooked the standalone example workflow: giget doesn't include the root pnpm-workspace.yaml, so catalog: dependencies would fail to resolve. Agreed that the examples should keep explicit versions. This PR is now closed.

@chenjiahan
chenjiahan deleted the chore/pnpm-catalog-20261118-124125 branch November 18, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants