Skip to content

feat(rspack): upgrade the Solid example to Solid 2 with solid-loader - #528

Merged
chenjiahan merged 4 commits into
mainfrom
chenjiahan/rspack-solid-v2
Nov 19, 2026
Merged

chenjiahan merged 4 commits into
mainfrom
chenjiahan/rspack-solid-v2

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Migrate the Rspack example to Solid 2 and render with @solidjs/web. A single rule uses solid-loader to compile JSX and TSX and the built-in SWC loader to handle plain TypeScript. The example keeps extensionless imports and enables Solid Refresh during development.

Verified the production build and confirmed in Chromium that editing a child component updates the page and preserves the parent counter.

Follow-up to #526. solid-loader v1.0.1.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T13:30:42.499019Z 6edd2a7 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan
chenjiahan merged commit d03b06c into main Nov 19, 2026
1 check passed
@chenjiahan
chenjiahan deleted the chenjiahan/rspack-solid-v2 branch November 19, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant