Skip to content

fix: default the Solid compiler root to the Rspack context - #11

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/default-solid-root
Nov 19, 2026
Merged

chenjiahan merged 1 commit into
mainfrom
chenjiahan/default-solid-root

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Solid source locations are relative to the process working directory by default, which can differ from an app’s Rspack context in a monorepo. Use the loader’s rootContext as the default for solid.root in both compiler backends. An explicit solid.root takes precedence.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T03:11:42.483842Z f2c3e2b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan
chenjiahan merged commit cdf7755 into main Nov 19, 2026
3 of 5 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/default-solid-root branch November 19, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant