Skip to content

test: give each Rspack test case its own fixtures - #17

Merged
chenjiahan merged 2 commits into
mainfrom
chenjiahan/organize-test-fixtures
Nov 19, 2026
Merged

chenjiahan merged 2 commits into
mainfrom
chenjiahan/organize-test-fixtures

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Group the six existing tests into plain TypeScript, SSR, and HMR cases. Each case keeps its index.test.ts, rspack.config.ts, and src together so the tested application is visible alongside its assertions. The HMR tests edit a temporary copy of their own source files and check that the parent counter survives the update.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T11:12:56.474439Z 9520ac5 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan
chenjiahan merged commit 747be53 into main Nov 19, 2026
3 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/organize-test-fixtures branch November 19, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant