Skip to content

fix(types): derive Solid options from the compiler - #9

Merged
chenjiahan merged 3 commits into
mainfrom
chenjiahan/type-hoist-props
Nov 19, 2026
Merged

chenjiahan merged 3 commits into
mainfrom
chenjiahan/type-hoist-props

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

The manually maintained SolidPresetOptions omitted compiler options such as hoistProps. Derive it from @solidjs/compiler and omit filename and sourceMap, which the loader supplies.

Typed configs now follow the compiler’s declarations for effectWrapper and memoWrapper. This narrows each option to its default helper name or false in Solid 2.0.0.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T03:07:15.774434Z 28c5bbd New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan chenjiahan changed the title fix(types): expose the Solid hoistProps option fix(types): derive Solid options from the compiler Nov 19, 2026
@chenjiahan
chenjiahan merged commit 559621c into main Nov 19, 2026
3 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/type-hoist-props branch November 19, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant