Repository navigation
Save edits to the main part it was read from, not always document.xml - #202
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files saved by Word for the web keep the main part in
word/document2.xml(#83).Document.openreads it through theword/document*.xmlglob, but#updatealways writes toword/document.xml. That entry is not in the zip, sosavedrops it and copies the originaldocument2.xml: every edit is lost, with no error.opennow remembers the entry it read, and#updatewrites back to it.Added a spec on
office365.docxthat edits the first paragraph, saves and reopens; it fails without the change.rake specpasses. Also checked with a template filled throughTextRun#substitute: before, the saved file still had{{name}}; after, it has the values.This keeps the glob. Resolving the part from
[Content_Types].xmlwould be a bigger change, so I left it out.