Repository navigation
Escape text and attribute values in to_html - #203
Merged
Merged
Conversation
TextRun#to_html and html_tag wrote document text and attribute values (link hrefs) into the HTML as is, so text such as "<name>" disappeared from the output and markup in a document came out as markup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_htmlwrites a run's text and a link'shrefinto the HTML without escaping. A paragraph with the textTerms: <name> & R&Drenders asTerms: & R&Din a browser, because<name>is read as a tag. If the document contains markup as text, that markup ends up in the page as real HTML.TextRun#to_htmlnow starts fromCGI.escapeHTML(@text), andhtml_tagescapes attribute values, which covers link hrefs from the relationships part.Added a spec to
document_spec.rb(escapes the document text); it fails without the change. All specs pass (296 examples).