Repository navigation
ssl: clear @callback_state before re-raising handshake callback exception - #1162
Open
luke-gruber wants to merge 1 commit into
Open
luke-gruber wants to merge 1 commit into
luke-gruber wants to merge 1 commit into
Conversation
…tion ossl_start_ssl() re-raises an exception saved by a callback (servername_cb, alpn_select_cb, session_get_cb, tmp_dh_callback, ...) with rb_jump_tag(), but leaves @callback_state set. If the application rescues the failed accept / connect and then calls #sysread / #syswrite on the same SSLSocket, ossl_ssl_read() / ossl_ssl_write() find the stale state and rb_jump_tag(TAG_RAISE) with no pending exception (errinfo is nil). The process then segfaults. Reset the ivar before jumping, as the read/write paths already do. The next I/O call then fails normally with OpenSSL::SSL::SSLError. NOTE: I couldn't find any misuses in the wild.
luke-gruber
force-pushed
the
fix_segfault_reuse_sock_after_cb_exception
branch
from
November 20, 2026 20:32
0cbee7a to
ed42e80
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ossl_start_ssl() re-raises an exception saved by a callback (servername_cb, alpn_select_cb, session_get_cb, tmp_dh_callback, ...) with rb_jump_tag(), but leaves @callback_state set. If the application rescues the failed accept / connect and then calls #sysread / #syswrite on the same SSLSocket, ossl_ssl_read() / ossl_ssl_write() find the stale state and rb_jump_tag(TAG_RAISE) with no pending exception (errinfo is nil). The process then segfaults.
Reset the ivar before jumping, as the read/write paths already do. The next I/O call then fails normally with OpenSSL::SSL::SSLError.
NOTE: I couldn't find any misuses in the wild.