Skip to content

ssl: clear @callback_state before re-raising handshake callback exception - #1162

Open
luke-gruber wants to merge 1 commit into
ruby:masterfrom
luke-gruber:fix_segfault_reuse_sock_after_cb_exception
Open

luke-gruber wants to merge 1 commit into
ruby:masterfrom
luke-gruber:fix_segfault_reuse_sock_after_cb_exception

Conversation

@luke-gruber

Copy link
Copy Markdown
Contributor

ossl_start_ssl() re-raises an exception saved by a callback (servername_cb, alpn_select_cb, session_get_cb, tmp_dh_callback, ...) with rb_jump_tag(), but leaves @callback_state set. If the application rescues the failed accept / connect and then calls #sysread / #syswrite on the same SSLSocket, ossl_ssl_read() / ossl_ssl_write() find the stale state and rb_jump_tag(TAG_RAISE) with no pending exception (errinfo is nil). The process then segfaults.

Reset the ivar before jumping, as the read/write paths already do. The next I/O call then fails normally with OpenSSL::SSL::SSLError.

NOTE: I couldn't find any misuses in the wild.

…tion

ossl_start_ssl() re-raises an exception saved by a callback (servername_cb,
alpn_select_cb, session_get_cb, tmp_dh_callback, ...) with rb_jump_tag(), but
leaves @callback_state set. If the application rescues the failed accept /
connect and then calls #sysread / #syswrite on the same SSLSocket,
ossl_ssl_read() / ossl_ssl_write() find the stale state and
rb_jump_tag(TAG_RAISE) with no pending exception (errinfo is nil).
The process then segfaults.

Reset the ivar before jumping, as the read/write paths already do. The next
I/O call then fails normally with OpenSSL::SSL::SSLError.

NOTE: I couldn't find any misuses in the wild.
@luke-gruber
luke-gruber force-pushed the fix_segfault_reuse_sock_after_cb_exception branch from 0cbee7a to ed42e80 Compare November 20, 2026 20:32

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant