Repository navigation
Conversation
Member
Author
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related work
Follow-up to the three regression-test requests in #430.
Changes
NotAcceptedandOutcomeUnknown. On acceptance, require exactly one probe followed by an UploadPart for part 1 of the same multipart upload, then check the payload and completion. Check that the reader stays unpolled on the other paths and that HTTP fallback requires a successful multipart abort after a decline. Probe reviewAll changes are in the
rc-s3unit tests and their transport fixture.Verification
cargo fmt --all --checkcargo test --locked -p rc-s3 --lib client::tests::native_transfercargo test --workspace --lockedcargo clippy --workspace --all-targets --locked -- -D warningsTemporarily bypassing the file-length check, declining an accepted probe, allowing fallback after a failed abort, and skipping the outstanding receipt wait caused all four new tests to fail. The workspace checks ran against the original implementation.
Three independent changes to the reader path verified the accepted-probe assertion. Substituting
PutObject, using a different upload ID, or sending part 2 each failed the test.