Skip to content

fix(fx): keep a tool result that shares a user message with text - #103

Merged
NishantJoshi00 merged 3 commits into
skillsynchq:mainfrom
JaynouOliver:fix/fx-tool-result-with-text
Nov 17, 2026
Merged

NishantJoshi00 merged 3 commits into
skillsynchq:mainfrom
JaynouOliver:fix/fx-tool-result-with-text

Conversation

@JaynouOliver

Copy link
Copy Markdown
Contributor

Issue: #102

What changed and why?

Converting a session to fx dropped a tool result when the user message carrying it also had text. The call was written with tool_results: [] and the text became the next prompt.

Now the turn that made the call also takes the results from that message; its text still opens the next turn.

Tested with cargo test -p txcript --test regression fx_: fails without the fix, passes with it.

One behaviour change: an aborted call answered by such a message is written as a committed turn with its result, not as interrupted.

I don't have fx installed, so I checked what txcript writes and reads back, not a resume in fx.

The fx writer took a user message holding both a tool result and text
for the next turn's prompt and read only its text, so the call was
written with no result.

The turn that made the call now takes the results from that message;
its text still opens the next turn.
@JaynouOliver
JaynouOliver marked this pull request as ready for review November 14, 2026 23:02
@NishantJoshi00

Copy link
Copy Markdown
Collaborator

Thanks @JaynouOliver, great catch. Losing tool results silently is the worst kind of bug.

@NishantJoshi00
NishantJoshi00 merged commit 14fd07c into skillsynchq:main Nov 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants