Repository navigation
fix(socket_mode): send frames over 64 KB with the 64-bit length form - #2046
Merged
WilliamBergamin merged 2 commits intoNov 16, 2026
Merged
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2046 +/- ##
==========================================
+ Coverage 84.45% 84.46% +0.01%
==========================================
Files 118 118
Lines 14039 14042 +3
==========================================
+ Hits 11856 11861 +5
+ Misses 2183 2181 -2 ☔ View full report in Codecov by Harness. |
WilliamBergamin
marked this pull request as ready for review
November 16, 2026 20:38
zimeg
approved these changes
Nov 16, 2026
zimeg
left a comment
Member
There was a problem hiding this comment.
🐍 LGTM! Thanks for catching this @WilliamBergamin, large ack() payloads will send now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request lets the builtin Socket Mode and RTM v2 clients send frames larger than 64 KB.
_build_data_frame_for_sendingonly had the 7-bit and 16-bit length forms, so any payload over 65535 bytes raisedstruct.error: 'H' format requires 0 <= number <= 65535. A largeack()payload, such as aresponse_actionwith a full view, could hit this.!Q), as RFC 6455 section 5.2 specifies. The receive path already handles it.Testing
The new tests fail on
mainand pass on this branch. They decode the frame header and unmask the body:Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.🤖 Generated with Claude Code