Repository navigation
docs: catch up with solid rc.22 for stable - #1698
Merged
Merged
Conversation
Regenerates the reference and diagnostics pages against solid next 0f6a978 (rc.22 plus four internal fixes) and fixes guides that rc.22 made wrong. - Generator: move the createDeferred caveats from CANONICAL_ROUTES to ENTRY_CAVEATS (#1693 put them in the route map, which broke sync:ref); add setTrustedTypesPolicy as a page, fold FlushChange and FlushLive into attribution, hide six @internal re-exports. - New pages: setTrustedTypesPolicy, and diagnostics CAUGHT_REACTIVE_READ, INVALID_HTML_NESTING, OPTIMISTIC_WRITE_BEFORE_LOAD, OPTIMISTIC_WRITE_WHILE_LOADING, STORE_WRITE_THROUGH_LOADING. - onFlush: each callback runs in its own flush (#4764). - Ref callbacks run in the creating pass and own nothing; an effect or onCleanup there throws in dev (#4768). - From React: handler expressions warn STRICT_READ_UNTRACKED (#4838). - Rendering and SSR: a common-problem entry for Trusted Types. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWNxvzLd4SQ3p3kgdA1
|
|
✅ Deploy Preview for solid-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
Description(required)
This PR regenerates the reference and diagnostics pages against solid
next0f6a978, which is rc.22 plus four internal store and signals fixes, and fixes the guides that rc.22 made wrong. Everything documented here shipped in rc.22.Generator (
scripts/extract-solid-ref.mjs)createDeferredcaveats insideCANONICAL_ROUTES. That gavecreateDeferreda second route entry, sosync:refcrashed partway through and deletedcreate-deferred.mdx. The caveats now live inENTRY_CAVEATS, and the generated page is byte-identical to the one on the branch.setTrustedTypesPolicypage (#4833);FlushChangeandFlushLive(#4725) folded intoattribution;heldRead,isHidden,setSwapHook,verdict,strictReadTrackedandstrictHandlerhidden. All six are tagged@internalupstream, but the scan does not see a tag on anexport { … } fromstatement.Regenerated reference
setTrustedTypesPolicy.onFlush: each callback now runs in its own flush (#4764). The page used to say the callbacks batch into one flush.DEV.setSignal(#4688), the newFlushEvent.changesand the slimmer observe hooks (#4725), andlowPriorityPreloadsonrenderToStringandrenderToStream(#4512). TherenderToStreampage also covers what happens when itssignalaborts.Diagnostics
Guides
onCleanupthrows. Before, the docs said refs run with no owner and that an effect inside one "never runs". Updated in concepts/components-and-jsx (including the pitfall heading), guides/integrate-non-solid-code and therefreference.onClick={ready() ? save : wait}row now points at STRICT_READ_UNTRACKED.TrustedHTMLassignment error, showing how to usesetTrustedTypesPolicy.Checks:
check:types,check:lint,prettier --check,lint:tone(0 errors; one existing warning on action.mdx) andpnpm buildall pass. I did not runcheck:examples, because it needs built local checkouts. Upstream nit, not fixed here: theonFlushJSDoc still contains "Don't", which breaks the no-contractions rule.Still not covered on the solid side: the repair skill has a FLUSH_IN_ACTION section but no diagnostics.json entry for it, so it gets no page.
Related issues & labels
Generated by Claude Code