Repository navigation
Conversation
Production builds set SITE_URL to https://docs.solidjs.com, so the sitemap and llms files use it and the noindex header for non-canonical hosts is not written. v2.solidjs.com 301s to the same path on docs.solidjs.com. Merge only once docs.solidjs.com points at this site. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWNxvzLd4SQ3p3kgdA1
|
|
✅ Deploy Preview for solid-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
Description(required)
Merge only once docs.solidjs.com points at this Netlify site. Until then, the redirect would send v2.solidjs.com visitors to the 1.x docs.
When
SITE_URLis unset, the build falls back toDEPLOY_PRIME_URL. That makes the site treat itself as non-canonical: every page getsX-Robots-Tag: noindex, and the sitemap and llms files use the Netlify host. If docs.solidjs.com became an alias of this site without a change, Google would drop docs.solidjs.com from its index.This PR changes
netlify.tomlonly:[context.production.environment] SITE_URL = "https://docs.solidjs.com". Production builds write no noindex header, and their sitemap,llms.txt,llms-full.txtandllms-small.txtuse docs.solidjs.com URLs. Deploy previews keep their own URL and the noindex header.https://v2.solidjs.com/*301s to the same path on docs.solidjs.com. Dev warnings in solid (diagnostics links), JSDoc@descriptionlinks and the AI tools page all point at v2.solidjs.com, so those links keep working and land on the canonical page. Their text can move to docs.solidjs.com later.Checked:
SITE_URL=https://docs.solidjs.com pnpm buildwrites no_headersfile, and all 287 llms.txt links and the sitemap<loc>s use docs.solidjs.com.Related issues & labels
Generated by Claude Code