Repository navigation
feat: radar, treemap and zenuml diagrams, icon setting, and code checks - #5
Merged
Merged
Conversation
…setting - radar-beta: axes on a circle, one point per curve and axis (further out and taller for higher values), one step per axis comparing curves. - treemap-beta: one column per top-level section (zone), nested sections and leaves below, block height follows the value, one step per section. - zenuml: read into the sequence model with a call stack: @Actor / @database annotators, group {}, @starter, sync calls with nested {}, async A->B, new X(), return, if/else/loop/par/try..., // comments become the step text. - Settings -> Icons: show or hide the emoji on blocks (2D and 3D); saved in the browser and carried in client links as &i=0. - Three new examples (team-skills, where-the-budget-goes, checkout-zenuml) in examples/ and the Examples menu; README tables, a new diagram-types-4 image, and refreshed Settings / cover / og images (23 types). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- npm run check: shared-block sync check, ESLint, TypeScript checkJs (0 errors) and TypeScript strict mode with a PHPStan-style baseline (tsc-baseline.json, 1997 known errors; any new error fails). - tools/extract-scripts.mjs copies the inline page scripts to .check/ keeping line numbers, so reports point at index.html / 3d.html lines. - GitHub Actions workflow runs the same checks on pushes and PRs. - Fixes found by the checks: useless regex escapes, let -> const, unused helper, promise executors returning values, stop() shadowing window.stop (now stopPlay), DOM typing casts, toast timer property. Parsing of all 21 existing examples is unchanged. - README: Code checks section, icons shown by default, project layout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the last three Mermaid diagram types (radar, treemap and ZenUML), a setting to show or hide the emoji icons, and lint and type checks with CI.
Diagram types
radar-betaaxislabels, curves given as value lists or asaxis: valuepairs, andmin/max.treemap-betaclassDef/:::classare ignored.zenuml@Actor/@Database-style annotators,group {}(zones),@Starter, sync callsA.method()with nested{}, asyncA->B: msg,new X()andreturn.if/else/loop/par/try… become the step tag, and a// commentabove a call becomes that step's text.The "not supported yet" message now lists all 23 types.
Icons on / off
&i=0when icons are hidden.Code checks (PHPStan level 10 style)
npm run checkruns four checks. GitHub Actions runs them on every push and PR (.github/workflows/check.yml).tools/sync-parser.py --checkcheckJsstrict, the PHPStan level 10 equivalenttsc-baseline.json(1,997 known, mostly parameters with no types yet)The page scripts live inside the HTML, so
tools/extract-scripts.mjscopies them to.check/*.jswith the same line numbers. Every error therefore points at the right line ofindex.html/3d.html.Fixes made to get the first three checks to zero:
letchanged toconstwhere nothing reassigns it;stop()renamed tostopPlay()in both pages, because inindex.htmlit shadowedwindow.stop;Checked: parsing of all 21 existing examples is identical to
main(nodes, links and step text compared), and each check fails on an injected bug.Icons are shown by default. Hiding them is opt-in and saved per browser.
Also
examples/, also added to the Examples menu:team-skills,where-the-budget-goesandcheckout-zenuml.diagram-types-4.png.og-image.png, which now say "23 diagram types".Testing
Run in headless Chromium:
&i=0and opens without icons.tools/sync-parser.py --checkreports the shared blocks in sync.Refs AHL-571.
🤖 Generated with Claude Code