Repository navigation
perf: look up parent package initializers by prefix in dead-code reachability - #139
Merged
Merged
Conversation
…hability Linking each module to the initializers of its parent packages compared every module with every other one and formatted a prefix string per pair, which grows quadratically with the module count. Each module now looks up its own dotted prefixes in a set of initializer names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dead-code reachability linked each module to the initializers of its parent packages by comparing it with every other module and formatting a prefix string per pair. That is quadratic in the module count, so large projects pay a growing share of
fensu checktime in this one loop.Changes
extract()indead_code/_helpers/graph.rsbuilds a set of initializer module names once, and each module looks up only its own dotted prefixes in it.Verification
make check-cipasses (ruff, ty,fensu check,cargo fmt --check, clippy, Rust self-check);cargo test -p fensu-factspasses, including the nested-initializer reachability cases.extract()time for 2k / 4k / 8k / 16k modules: