Skip to content

fix(deps): pin SQLQuack 0.18.1 - #86

Closed
kvlonge wants to merge 1 commit into
mainfrom
fix/pin-sqlquack-0.18.1
Closed

kvlonge wants to merge 1 commit into
mainfrom
fix/pin-sqlquack-0.18.1

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Why

SQLQuack 0.18.1 is published. SQLClean still pins 0.12.1, and SQLClean and SQLBuild link one SQLQuack, so SQLClean moves first.

Changes

  • All six direct sqlquack-* pins in Cargo.toml move from 75d4c848 (0.12.1) to ae2bef7a (the v0.18.1 tag). Cargo.lock updates only the SQLQuack packages, with no new dependencies.
  • No source, formatter, lint or fixture changes. SQLClean reads none of the fields SQLQuack renamed or added since 0.12.1 (set_quantifier, ctes_outside, the new optional struct fields).
  • Results change only through SQLQuack fixes, for narrow cases:
    • Snowflake, fix(snowflake): read // straight after a stage as its path (0.17.0): // written straight after a stage reference is now part of its path, not a comment. LIST @orders_stage// note now parses (0.9.6 refused it); SELECT $1 FROM @orders_stage// note is now a syntax error, so a comment needs a space or punctuation before it. The fingerprints of such SQL change once.
    • Databricks, fix(databricks): keep the formatter and lint refusing forms whose trees are not reviewed (0.18.0).

Verification

  • cargo test --all passes (40 + 8 tests), including the format corpus: every dialect, Snowflake included, matches its recorded layouts byte for byte, with the same formatted and refused counts. The T-SQL lint test stays ignored, as before.
  • Python tests pass (72) on the extension rebuilt against the new pin.
  • make check-ci passes.
  • Compared the 0.9.6 release from PyPI with this build on Snowflake files (facts, format, check --no-cache): SELECT DISTINCT with COUNT(DISTINCT …), a subquery holding a CTE, a plain SELECT, and nested function calls at depths 70 to 600. Output is identical; only the stage cases above differ. SQLQuack's default function-call depth rose from 64 to 256, but SQLClean sets its own limit, so both builds refuse the same deep nesting with the same message.

All six sqlquack crates move from 0.12.1 to the v0.18.1 tag together.
SQLClean reads none of the renamed or added SQLQuack fields, so no code
changes, and the format corpus is unchanged in every dialect.

Two SQLQuack fixes change results for narrow cases. In Snowflake, `//`
written straight after a stage reference is now part of the stage path
rather than a comment: `LIST @orders_stage//x` parses, a `//` comment
must be separated from a stage by a space or punctuation, and the
fingerprints of such SQL change once. In Databricks, the formatter and
lint refuse forms whose trees SQLQuack has not reviewed.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying sqlclean with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d46f59
Status:⚡️  Build in progress...

View logs

@kvlonge kvlonge closed this Nov 18, 2026
@kvlonge
kvlonge deleted the fix/pin-sqlquack-0.18.1 branch November 18, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant