Repository navigation
fix(deps): pin SQLQuack 0.18.1 - #87
Merged
Merged
Conversation
All six sqlquack crates move from 0.12.1 to the v0.18.1 tag together. SQLClean reads none of the renamed or added SQLQuack fields, so no code changes, and the format corpus is unchanged in every dialect. Two SQLQuack fixes change results for narrow cases. In Snowflake, `//` written straight after a stage reference is now part of the stage path rather than a comment: `LIST @orders_stage//x` parses, a `//` comment must be separated from a stage by a space or punctuation, and the fingerprints of such SQL change once. In Databricks, the formatter and lint refuse forms whose trees SQLQuack has not reviewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLQuack 0.18.1 is published. SQLClean still pins 0.12.1, and SQLClean and SQLBuild link one SQLQuack, so SQLClean moves first.
Changes
sqlquack-*pins inCargo.tomlmove from75d4c848(0.12.1) toae2bef7a(the v0.18.1 tag).Cargo.lockupdates only the SQLQuack packages, with no new dependencies.set_quantifier,ctes_outside, the new optional struct fields).fix(snowflake): read // straight after a stage as its path(0.17.0)://written straight after a stage reference is now part of its path, not a comment.LIST @orders_stage// notenow parses (0.9.6 refused it);SELECT $1 FROM @orders_stage// noteis now a syntax error, so a comment needs a space or punctuation before it. The fingerprints of such SQL change once.fix(databricks): keep the formatter and lint refusing forms whose trees are not reviewed(0.18.0).Verification
cargo test --allpasses (40 + 8 tests), including the format corpus: every dialect, Snowflake included, matches its recorded layouts byte for byte, with the same formatted and refused counts. The T-SQL lint test stays ignored, as before.make check-cipasses.facts,format,check --no-cache):SELECT DISTINCTwithCOUNT(DISTINCT …), a subquery holding a CTE, a plainSELECT, and nested function calls at depths 70 to 600. Output is identical; only the stage cases above differ. SQLQuack's default function-call depth rose from 64 to 256, but SQLClean sets its own limit, so both builds refuse the same deep nesting with the same message.