Repository navigation
feat!: pin SQLQuack 0.22.0 and document the 512 nesting ceiling - #93
Merged
Merged
Conversation
SQLQuack 0.22.0 makes max_function_call_depth the exact limit in every linted dialect and refuses any statement nested past 512 levels in Postgres, BigQuery and Databricks too, as it already did in Snowflake and DuckDB. At 512 a refusal of SQL that calls something explains the ceiling; call-free SQL gets the bare refusal. - format passes whether the SQL calls anything to SQLQuack's refusal hint, so a format refusal at 512 explains the ceiling as check does. - Join facts read each comma item's joins, which SQLQuack now keeps with the item in Postgres and Databricks, so facts match 0.10.0. - Configuration and embedding docs say the statement and every expression around the calls count toward 512. - CLI tests cover the limits in Databricks, BigQuery and Postgres. BREAKING CHANGE: Postgres, BigQuery and Databricks files nested more than 512 levels deep, such as 600 UNION ALL operands, are now a SQLCLEAN999 finding and are left as written by format.
Deploying sqlclean with
|
| Latest commit: |
48bc86c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://546f1bc3.sqlclean.pages.dev |
| Branch Preview URL: | https://feat-sqlquack-0-22.sqlclean.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLQuack 0.22.0 is published. It makes
max_function_call_depththe exact limit in every linted dialect: before, Databricks and BigQuery stopped at 198 nested calls and Postgres at 299, whatever the setting. It also refuses any Postgres, BigQuery or Databricks statement nested past 512 levels, as Snowflake and DuckDB already did. At 512 the refusal explains the ceiling only when the SQL calls something.Changes
sqlquack-*crates to the v0.22.0 tag.sqlclean factshad started reporting no joins forFROM a JOIN b ON true, c.BREAKING CHANGE: Postgres, BigQuery and Databricks files nested more than 512 levels deep, such as 600 UNION ALL operands, are now a SQLCLEAN999 finding and are left as written by format.
Verification
cargo test --all(42 + 8), Python tests (95) andmake check-cipass.sqlclean factsjoins match 0.10.0 on 62 join shapes in 5 dialects, andfacts,formatandcheckmatch 0.10.0 byte for byte on the Snowflake comparison files.