Skip to content

fix(argo-cd): Switch to garage, remove NS restriction - #486

Merged
adwk67 merged 4 commits into
mainfrom
fix/argo-cd-pre-26.11
Nov 13, 2026
Merged

adwk67 merged 4 commits into
mainfrom
fix/argo-cd-pre-26.11

Conversation

@adwk67

@adwk67 adwk67 commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Description

Part of #474

N.B. the garage file differs slightly from the one in templates as the secret should come from a sealed-secret, in keeping with elsewhere in the demo.

Changes

  • replace minio with garage
  • remove namespace restriction
  • filter repo fetched by gitsync to include only relevant folders
  • add placeholders for the update script to pick up so that subsequent releases have correct branch/version refs
  • update docs

Tested and works:

image image

Not tested: changing things in a reomte repo and pulling from there.

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

@adwk67 adwk67 self-assigned this Nov 12, 2026
@adwk67
adwk67 marked this pull request as ready for review November 12, 2026 12:06
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Nov 12, 2026
@Techassi
Techassi self-requested a review November 12, 2026 12:08
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 12, 2026

@Techassi Techassi left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review - I didn't look at the Garage manifests. Maybe @NickLarsenNZ can have a look as he migrated a whole bunch of MinIO demos to Garage.

All other changes looked good.

@adwk67
adwk67 requested a review from NickLarsenNZ November 12, 2026 13:40
NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 13, 2026

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the effort

Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@adwk67
adwk67 merged commit ecddc44 into main Nov 13, 2026
2 checks passed
@adwk67
adwk67 deleted the fix/argo-cd-pre-26.11 branch November 13, 2026 08:33
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Nov 13, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants