Repository navigation
Migrate the plugin runtime to asyncio - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the plugin runtime to asyncio while keeping the console entry point synchronous and preserving ordered dispatch for both synchronous and asynchronous handlers. WebSocket operations, listener iteration and cleanup,
PluginManager.run(), and command-sender methods now use async APIs. Listener cleanup attempts every registration and preserves a primary runtime failure while grouping ordinary cleanup failures.The README examples reflect the async handler and custom listener contracts. Tests cover listener merging and cleanup, ordered sync/async dispatch, WebSocket lifecycle and error handling, registration payload parity, and cancellation cleanup.
Compatibility: custom listeners and direct
PluginManager.run()callers must migrate to the async APIs; command-sender calls must be awaited. Existing synchronous handlers remain supported.Validation: 201 tests pass on Python 3.10.22 and Python 3.15.2;
mypy streamdeck, focused Ruff checks,uv lock --check, andgit diff --checkpass.