Skip to content

Migrate to TypeScript & fix Netlify PR previews - #261

Merged
hirasso merged 7 commits into
mainfrom
migrate-to-typescript
Nov 17, 2026
Merged

hirasso merged 7 commits into
mainfrom
migrate-to-typescript

Conversation

@hirasso

@hirasso hirasso commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Description

This repo now supports Renovate PRs for swup and @swup/* packages, including automatic merges and re-deployment for minor versions 🤠

This PR should be merged before we proceed to testing the two remaining major version bumps for @swup/a11y-plugin and @swup/preload-plugin.

  • npm update
  • src/_assets/*.js → .ts, typed under strict mode
  • smoke tests and playwright config → .ts
  • webpack.config.mjs type-checked via @ts-check
  • swup.config.mjs stays .mjs: cosmiconfig needs the typescript JS API, gone in TS 7
  • bump .nvmrc to 24 (matches CI)

Drive-By

  • update sass and fix all deprecation warnings
  • just realized that the PR preview deploys via Netlify are gone 😂 – last one was 2025. Fixed here as well.

Checks

  • The PR is submitted to the main branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included

importMeta: false broke css-loader's `new URL(..., import.meta.url)`
- src/_assets/*.js → .ts, typed under strict mode
- smoke tests and playwright config → .ts
- webpack.config.mjs type-checked via @ts-check
- swup.config.mjs stays .mjs: cosmiconfig needs the typescript JS API, gone in TS 7
- bump .nvmrc to 24 (matches CI)
`stylesExpectedToChange` isn't a CLI option (it's `styles`) and matched the defaults anyway
@hirasso
hirasso requested a review from daun November 11, 2026 16:16
@hirasso
hirasso marked this pull request as draft November 11, 2026 16:17
@hirasso hirasso closed this Nov 11, 2026
@hirasso hirasso reopened this Nov 11, 2026
@hirasso
hirasso marked this pull request as ready for review November 11, 2026 16:39
@netlify

netlify Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for swup-docs ready!

Name Link
🔨 Latest commit 47aa29d
🔍 Latest deploy log https://app.netlify.com/projects/swup-docs/deploys/6af49ddb45eb5c5f3123f3a9
😎 Deploy Preview https://deploy-preview-261--swup-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hirasso hirasso changed the title Migrate to typescript Migrate to typescript & fix Netlify PR previews Nov 11, 2026
@hirasso

hirasso commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

Netlify is creating previews again... ready to merge this one I guess :)

@hirasso hirasso changed the title Migrate to typescript & fix Netlify PR previews Migrate to TypeScript & fix Netlify PR previews Nov 11, 2026
@hirasso
hirasso enabled auto-merge November 14, 2026 07:42

@daun daun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥬

@hirasso
hirasso merged commit c66fa4c into main Nov 17, 2026
5 checks passed
@hirasso
hirasso deleted the migrate-to-typescript branch November 17, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants