Repository navigation
CU-z8zyy1rdhq fix: run only pending upgrades and record current plugi… - #47
Merged
Merged
Conversation
[Medium impact] The PR appears safe to merge; no new blocking issues were found. SummaryThe PR stops completed upgrades from running again and preserves the saved JavaScript API key.
No new actionable issues found. eug-L accepted the lack of regression tests as intentional: adding isolated tests would require extra setup, and release upgrades are checked by hand. Reviews (2) · Last reviewed commit: "chore: Bump versions to 0.9.5" · Reviewed by Greptile |
The upgrade manager stored each upgrade's version instead of the current plugin version, so tawkto-version stayed at 0.9.0 and the upgrades re-ran on every request. The 0.9.0 upgrade then reset the Javascript API key, breaking Secure Mode for logged-in visitors. - Only run upgrades newer than the stored version and up to the current one - Store the current plugin version once after the upgrades run - Only initialise the security option in the 0.9.0 upgrade if it is missing - Add 0.9.4 changelog entry
- Move the Javascript API key fix to the 0.9.5 changelog entry - Refresh composer.lock content-hash
eug-L
force-pushed
the
fix/upgrade-manager
branch
from
November 19, 2026 02:39
19dbb40 to
c44d5b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n version
The upgrade manager stored each upgrade's version instead of the current plugin version, so tawkto-version stayed at 0.9.0 and the upgrades re-ran on every request. The 0.9.0 upgrade then reset the Javascript API key, breaking Secure Mode for logged-in visitors.