Skip to content

CU-z8zyy1rdhq fix: run only pending upgrades and record current plugi… - #47

Merged
eug-L merged 2 commits into
masterfrom
fix/upgrade-manager
Nov 19, 2026
Merged

eug-L merged 2 commits into
masterfrom
fix/upgrade-manager

Conversation

@eug-L

@eug-L eug-L commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

…n version

The upgrade manager stored each upgrade's version instead of the current plugin version, so tawkto-version stayed at 0.9.0 and the upgrades re-ran on every request. The 0.9.0 upgrade then reset the Javascript API key, breaking Secure Mode for logged-in visitors.

  • Only run upgrades newer than the stored version and up to the current one
  • Store the current plugin version once after the upgrades run
  • Only initialise the security option in the 0.9.0 upgrade if it is missing
  • Add 0.9.4 changelog entry

@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new blocking issues were found.

Summary

The PR stops completed upgrades from running again and preserves the saved JavaScript API key.

  • Upgrade checks now save the installed plugin version.
  • The 0.9.0 upgrade keeps an existing JavaScript API key.

No new actionable issues found. eug-L accepted the lack of regression tests as intentional: adding isolated tests would require extra setup, and release upgrades are checked by hand.

Reviews (2) · Last reviewed commit: "chore: Bump versions to 0.9.5" · Reviewed by Greptile

Comment thread tawkto/upgrade.manager.php Resolved
The upgrade manager stored each upgrade's version instead of the current
plugin version, so tawkto-version stayed at 0.9.0 and the upgrades re-ran
on every request. The 0.9.0 upgrade then reset the Javascript API key,
breaking Secure Mode for logged-in visitors.

- Only run upgrades newer than the stored version and up to the current one
- Store the current plugin version once after the upgrades run
- Only initialise the security option in the 0.9.0 upgrade if it is missing
- Add 0.9.4 changelog entry
- Move the Javascript API key fix to the 0.9.5 changelog entry
- Refresh composer.lock content-hash
@eug-L
eug-L force-pushed the fix/upgrade-manager branch from 19dbb40 to c44d5b5 Compare November 19, 2026 02:39
@eug-L
eug-L merged commit 3d53087 into master Nov 19, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant