Repository navigation
fix(generate-screenshots): Capture nested example folders, emulate reduced motion, recover from failures - #113
Merged
Conversation
🦋 Changeset detectedLatest commit: f6537d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@layerstack/docs
@layerstack/svelte-actions
@layerstack/svelte-state
@layerstack/svelte-stores
@layerstack/svelte-table
@layerstack/tailwind
@layerstack/utils
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate-screenshotsmissed every@layerchart/webglexample in LayerChart's docs (see the bot PR techniq/layerchart#1002), and a single slow example failed the run for the rest.Changes
src/examples/components/webgl/<Component>/*.sveltewas seen as an emptywebglcomponent. Any folder holding.sveltefiles is now a component named by its path (ex.webgl/Points), matching the/screenshots/webgl/Points/…pathsExampleScreenshotalready requests. Orphan cleanup walks into these folders too; before, it would have removedscreenshots/webgl/as an unknown component on every run.prefers-reduced-motion: reduce. Screenshots are stills, and examples that animate on their own can stop redrawing. In headless Chromium, WebGL is software-rendered (SwiftShader, locally and on CI), so a continuously spinning 300k-point example ran at about 1 fps and its element screenshot never finished.Verified
Ran against the LayerChart docs dev server: 1080 examples, 0 errors, and all 44 webgl examples captured, checked by eye in light and dark mode. LayerChart's two auto-animating examples are updated to respect reduced motion in a separate change.
🤖 Generated with Claude Code