Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/rfc/stovepipe/steps/buildsignal.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ Two-tier cadence, matching SubmitQueue:
| `accepted` | `BuildSignal.AcceptedPollDelayMs` (default 5000ms) | Queued by the runner, not started — poll infrequently. |
| `running` | `BuildSignal.RunningPollDelayMs` (default 2000ms) | Actively executing — poll more often. |

Each delivery resolves these settings through the queue configuration store. Hosts apply a service baseline, deployment-wide settings, and per-queue overrides before supplying immutable configurations. The reference server embeds its baseline YAML and layers an optional configuration file over it. See the [configuration guide](../../../../service/stovepipe/server/README.md).
Each delivery resolves these settings through the queue configuration store. Hosts apply a service baseline, deployment-wide settings, and per-queue overrides before supplying immutable configurations. The reference server embeds its baseline YAML and layers an optional configuration file over it; the e2e profile selects shorter positive waits without changing consumer retry behavior. See the [configuration guide](../../../../service/stovepipe/server/README.md).

## Error classification

Expand Down
2 changes: 1 addition & 1 deletion service/stovepipe/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ The Stovepipe controllers live under [`stovepipe/controller/`](../../stovepipe/c

## Queue and stage configuration

The server accepts an optional `-config` YAML file for deployment-wide queue and stage settings and per-queue overrides. See the [configuration guide](server/README.md) for settings, validation. The service always loads its embedded baseline; the optional file overrides it.
The server accepts an optional `-config` YAML file for deployment-wide queue and stage settings and per-queue overrides. See the [configuration guide](server/README.md) for settings, validation, and the isolated end-to-end profile. The service always loads its embedded baseline; the optional file overrides it.

## Running

Expand Down
6 changes: 6 additions & 0 deletions service/stovepipe/server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,9 @@ Deployment-wide stage settings from the optional file override the service basel
Every queue override must name a queue in `MQ_TENANTS`; queues without overrides inherit the deployment configuration. Queue registration is separate from stage settings. The static store only serves registered queues.

The baseline retains a concurrency limit of one, a five-second admission wait, five-second accepted-build polling, two-second running-build polling, two-minute build analysis polling, and thirty-second issue refresh and recovery waits. These values are defined only in the baseline YAML.

## End-to-end profile

The Stovepipe e2e suite stages its own override file and selects it through a Compose overlay. All periodic stage waits and the admission wait become 250 milliseconds; unspecified settings, including concurrency, inherit the service baseline. Immediate batch continuation and consumer retry policies are unchanged. Ordinary local Compose runs do not select the e2e profile.

Run the real-stack suite locally with `bazel test //test/e2e/stovepipe:go_default_test --nocache_test_results`. Bazel supplies the server binary, Compose overlay, and override file through declared inputs; the baseline is embedded in the binary. The runner timeout remains the existing safety ceiling rather than the normal runtime target.
2 changes: 2 additions & 0 deletions test/e2e/stovepipe/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ go_test(
"suite_test.go",
],
data = [
"docker-compose.e2e.yml",
"stovepipe.yaml",
"//platform/extension/counter/mysql/schema",
"//platform/extension/messagequeue/mysql/schema",
"//service/stovepipe:docker-compose.yml",
Expand Down
8 changes: 8 additions & 0 deletions test/e2e/stovepipe/docker-compose.e2e.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
services:
stovepipe-service:
command: ["./stovepipe", "-config", "/etc/stovepipe/config.yaml"]
volumes:
- type: bind
source: ${REPO_ROOT}/test/e2e/stovepipe/stovepipe.yaml
target: /etc/stovepipe/config.yaml
read_only: true
12 changes: 12 additions & 0 deletions test/e2e/stovepipe/stovepipe.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
queueconfig:
stages:
process:
gateWaitDelay: 250ms
buildSignal:
acceptedPollDelay: 250ms
runningPollDelay: 250ms
buildAnalysis:
pollDelay: 250ms
issueTrack:
refreshDelay: 250ms
recoveryWaitDelay: 250ms
12 changes: 10 additions & 2 deletions test/e2e/stovepipe/suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,19 @@ func (s *StovepipeE2ESuite) SetupSuite() {
s.log.Logf("Starting Stovepipe e2e test suite using docker-compose")

composeFile := testutil.Runfile("service/stovepipe/docker-compose.yml")
s.stack = testutil.NewComposeStack(t, s.log, s.ctx, composeFile, "e2e-stovepipe",
s.stack = testutil.NewComposeStack(
t,
s.log,
s.ctx,
composeFile,
"e2e-stovepipe",
testutil.WithOverlay(testutil.Runfile("test/e2e/stovepipe/docker-compose.e2e.yml")),
testutil.WithBuildContext(map[string]string{
"test/e2e/stovepipe/stovepipe.yaml": "test/e2e/stovepipe/stovepipe.yaml",
".docker-bin/stovepipe": "service/stovepipe/server/stovepipe_linux",
"service/stovepipe/server/Dockerfile": "service/stovepipe/server/Dockerfile",
}))
}),
)

err := s.stack.Up("mysql-app", "mysql-queue")
require.NoError(t, err, "failed to start compose stack")
Expand Down
Loading