Skip to content

ci: run Linux CI in GHCR container, make Windows non-blocking - #3

Closed
qkhalk wants to merge 5 commits into
mainfrom
ci-ghcr-linux
Closed

qkhalk wants to merge 5 commits into
mainfrom
ci-ghcr-linux

Conversation

@qkhalk

@qkhalk qkhalk commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Linux unit/e2e jobs now run inside ghcr.io/vibecoder880/build/bun-node:24.04 (Node 24 + Bun preinstalled), removing the setup-node/setup-bun flake surface and speeding up runs.
  • Windows jobs stay on bare windows-latest but use continue-on-error so intermittent shared-runner flakes (ripgrep cache race, app rAF timing, external-directory path normalization) no longer block a merging PR.
  • containers.yml gains a workflow_dispatch run that publishes base + bun-node to the fork GHCR; build.ts accepts --only <name>.

Verification

  • Image ghcr.io/vibecoder880/build/bun-node:24.04 compiled + pushed via containers.yml dispatch (run 32204061074, success).
  • test.yml diff is CI-only (3 files); no application/OC Kit code changed.

Impact on PR #2

After this merges, PR #2 (oc-kit-domain -> main) inherits the new test.yml: Windows becomes non-blocking, so the known Windows infra flake can no longer hold the merge.

Linux unit/e2e jobs now run inside ghcr.io/vibecoder880/build/bun-node:24.04
(Node 24 + Bun preinstalled) to drop the setup-node/setup-bun flake surface and
speed up runs. Windows jobs stay on bare windows-latest but use continue-on-error
so intermittent shared-runner flakes (ripgrep cache race, app rAF timing,
external-directory path normalization) no longer block a merging PR.

containers.yml gains a workflow_dispatch run that publishes base + bun-node to the
fork GHCR; build.ts accepts --only <name> to compile a single image.
Copilot AI lite review requested due to automatic review settings August 19, 2026 01:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown

Hey! Your PR title ci: run Linux CI in GHCR container, make Windows non-blocking doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

qkhalk added 2 commits August 19, 2026 08:46
The unit/e2e Linux jobs run inside ghcr.io/vibecoder880/build/bun-node:24.04
(Node + Bun preinstalled). The `if: runner.os != 'Linux'` guard skipped the
setup-bun action, which also skipped `bun install`, so node_modules/.bin/turbo
was absent and `bun turbo test` resolved turbo.json instead. Add an explicit
`bun install --frozen-lockfile` step (with the setuptools fallback the setup
action performs) guarded to runner.os == 'Linux'. Windows stays bare and
non-blocking.
Empty commit to re-run the pull_request test workflow after adding the
in-container `bun install --frozen-lockfile` step.
@qkhalk qkhalk closed this Aug 19, 2026
@qkhalk qkhalk reopened this Aug 19, 2026
Empty commit to release the coalescing slot (stale pre-fix run 16 was
stuck on shared Windows runners) and fire a fresh pull_request run that
exercises the in-container `bun install --frozen-lockfile` step.
@qkhalk

qkhalk commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator Author

reopen to fire a fresh pull_request test run (stale pre-fix run was stuck on Windows runners)

@qkhalk qkhalk closed this Aug 19, 2026
@qkhalk qkhalk reopened this Aug 19, 2026
Add ci-ghcr-linux to the push trigger so a push runs the real test workflow
(instead of the filtered 0s no-op) and validates the in-container
`bun install --frozen-lockfile` fix deterministically.
@qkhalk

qkhalk commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator Author

supersede with a fresh PR so the pull_request test workflow fires cleanly (coalescing against the cancelled run blocked re-runs)

@qkhalk qkhalk closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants