Repository navigation
Conversation
Linux unit/e2e jobs now run inside ghcr.io/vibecoder880/build/bun-node:24.04 (Node 24 + Bun preinstalled) to drop the setup-node/setup-bun flake surface and speed up runs. Windows jobs stay on bare windows-latest but use continue-on-error so intermittent shared-runner flakes (ripgrep cache race, app rAF timing, external-directory path normalization) no longer block a merging PR. containers.yml gains a workflow_dispatch run that publishes base + bun-node to the fork GHCR; build.ts accepts --only <name> to compile a single image.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
The unit/e2e Linux jobs run inside ghcr.io/vibecoder880/build/bun-node:24.04 (Node + Bun preinstalled). The `if: runner.os != 'Linux'` guard skipped the setup-bun action, which also skipped `bun install`, so node_modules/.bin/turbo was absent and `bun turbo test` resolved turbo.json instead. Add an explicit `bun install --frozen-lockfile` step (with the setuptools fallback the setup action performs) guarded to runner.os == 'Linux'. Windows stays bare and non-blocking.
Empty commit to re-run the pull_request test workflow after adding the in-container `bun install --frozen-lockfile` step.
Empty commit to release the coalescing slot (stale pre-fix run 16 was stuck on shared Windows runners) and fire a fresh pull_request run that exercises the in-container `bun install --frozen-lockfile` step.
Collaborator
Author
|
reopen to fire a fresh pull_request test run (stale pre-fix run was stuck on Windows runners) |
Add ci-ghcr-linux to the push trigger so a push runs the real test workflow (instead of the filtered 0s no-op) and validates the in-container `bun install --frozen-lockfile` fix deterministically.
Collaborator
Author
|
supersede with a fresh PR so the pull_request test workflow fires cleanly (coalescing against the cancelled run blocked re-runs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unit/e2ejobs now run insideghcr.io/vibecoder880/build/bun-node:24.04(Node 24 + Bun preinstalled), removing the setup-node/setup-bun flake surface and speeding up runs.windows-latestbut usecontinue-on-errorso intermittent shared-runner flakes (ripgrep cache race, app rAF timing, external-directory path normalization) no longer block a merging PR.containers.ymlgains aworkflow_dispatchrun that publishesbase+bun-nodeto the fork GHCR;build.tsaccepts--only <name>.Verification
ghcr.io/vibecoder880/build/bun-node:24.04compiled + pushed viacontainers.ymldispatch (run 32204061074, success).test.ymldiff is CI-only (3 files); no application/OC Kit code changed.Impact on PR #2
After this merges, PR #2 (
oc-kit-domain->main) inherits the newtest.yml: Windows becomes non-blocking, so the known Windows infra flake can no longer hold the merge.