Repository navigation
Conversation
The Postfix start script ran "postfix start $SERVICE_POSTFIX_OPTS", but postfix takes its options before the command, so the variable had no effect. It now runs "postfix $SERVICE_POSTFIX_OPTS start", so -v, -D and -c work. A new image test of the development images sets SERVICE_POSTFIX_OPTS to -v and finds the verbose messages in the container log, on Debian through syslog. The variable is documented, and its known issue is removed.
|
Kanti
marked this pull request as ready for review
November 18, 2026 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
The Postfix start script ran
postfix start $SERVICE_POSTFIX_OPTS.postfixtakes its options before the command (postfix [-Dv] [-c config_dir] command), so the variable had no effect. The script now runspostfix $SERVICE_POSTFIX_OPTS start, so-v,-Dand-cwork.Related issues: none found.
Changes
provisioning/base/general/bin/service.d/postfix.sh: options beforestart;make generate.testPostfixOptionsFromTheEnvironmentinPostfixChecks(development images, where Postfix runs): in a container withSERVICE_POSTFIX_OPTS=-v, the verbose messagename_maskshows up in the container log, on Alpine aspostfix: name_mask: …, on Debian through syslog aspostfix[pid]: name_mask: ….docs/environment-variables.md:SERVICE_POSTFIX_OPTSunder Services.docs/known-issues.md: the entry forSERVICE_POSTFIX_OPTSis removed.AGENTS.md: its example of a variable that a script reads without effect wasSERVICE_POSTFIX_OPTS; it now says that the variable used to be passed afterstart.How it was verified
The published development images with
SERVICE_POSTFIX_OPTS=-v, and the same images with the newpostfix.shmounted over/opt/docker/bin/service.d/postfix.sh(mode 755):postfix.shphp-dev:8.5name_maskline[SYSLOG] postfix[90]: name_mask: allin the container logphp-dev:8.5-alpinename_masklinepostfix: name_mask: ipv4and three more in the container logWithout
SERVICE_POSTFIX_OPTS, Postfix runs with the new script as before, without verbose messages, on both.Image tests from the fork: on the published
php-dev:8.5andphp-dev:8.5-alpinethe new test fails (no verbose message); with the newpostfix.shit passes, together with the other Postfix tests.Rebased on master with #634;
ci/console generatechanges nothing else. The CI run of this pull request runs the new test in the development images, Debian and Alpine, amd64 and arm64.Not verified:
-cwith another configuration directory.