Skip to content

Remove unmatched PHPStan ignore rule - #85

Merged
swissspidy merged 1 commit into
mainfrom
claude/focused-archimedes-04f18x
Nov 17, 2026
Merged

swissspidy merged 1 commit into
mainfrom
claude/focused-archimedes-04f18x

Conversation

@swissspidy

@swissspidy swissspidy commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

PHPStan now fails with Ignored error pattern missingType.return was not matched in reported errors (see https://github.com/wp-cli/admin-command/actions/runs/44002894977/job/133771065296). This removes the stale ignoreErrors entry from phpstan.neon.dist.


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Updated project checks so missing return-type information is no longer excluded from static analysis. This may surface additional analysis warnings during development; no changes to application behavior or user-facing features are included.

The missingType.return ignore pattern no longer matches any reported
errors, which PHPStan now reports as an error.

Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UWTd5pBoZVKWB36aEppMHt
@swissspidy
swissspidy requested a review from a team as a code owner November 17, 2026 16:51
Copilot AI balanced review requested due to automatic review settings November 17, 2026 16:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The PHPStan configuration no longer ignores the missingType.return rule.

Changes: PHPStan configuration

Layer / File(s) Summary
Remove return-type rule ignore
phpstan.neon.dist
The configuration no longer ignores missingType.return.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: brianhenryie

Merge Risk: Minimal · up to 08912

This change removes an unused PHPStan ignore rule so that static analysis no longer fails on an unmatched pattern. It does not affect runtime behavior. The merge risk is minimal.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added bug command:admin Related to 'admin' command scope:testing Related to testing labels Nov 17, 2026
@swissspidy
swissspidy merged commit 9db930a into main Nov 17, 2026
57 of 58 checks passed
@swissspidy
swissspidy deleted the claude/focused-archimedes-04f18x branch November 17, 2026 16:52
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug command:admin Related to 'admin' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants