Repository navigation
Skip fork-dependent scenarios without pcntl and test the fallback - #8
Conversation
Scenarios that check for a shared worker or for WordPress reloading need the pcntl extension, which the Docker images the tests run in lacked. Tag them so they are skipped where it is missing, and add a scenario for the fallback to separate processes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UWTd5oZXFWfL1mxtssHXwz
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
CI started failing once the Behat scenarios began running in Docker containers whose PHP lacks
pcntl(failing run). The root cause is fixed in wp-cli/wp-cli-tests by installingpcntlin the image (wp-cli/wp-cli-tests PR from branchclaude/eager-cerf-n46bjx).This PR makes the suite here cope with an environment that has no
pcntl:@require-extension-pcntl, so they are skipped there instead of failing. These are the scenarios that check forStarting workerandReloading WordPress…. The tag is evaluated inside the container, so it also works under Docker.pcntl_forkthroughWP_CLI_PHP_ARGSand checks for the warning and correct output.The scenarios that expect empty STDERR still fail without
pcntl, because of the warning, so this PR depends on the wp-cli-tests change.Generated by Claude Code
Summary by CodeRabbit
pcntlextension.