Skip to content

Fix targeted review continuation and configurable execution timeouts - #59

Merged
AppSolves merged 2 commits into
mainfrom
fix/targeted-review-progress-and-timeouts
Nov 16, 2026
Merged

AppSolves merged 2 commits into
mainfrom
fix/targeted-review-progress-and-timeouts

Conversation

@AppSolves

@AppSolves AppSolves commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

Large reviews previously re-sent whole groups during continuation and could spend their execution budget before later groups or synthesis. This change checkpoints assigned files, orders changed dependencies together, gives every group a first pass, and continues only unfinished work without discarding validated findings.

trusted plan → first pass for every group → pending-file continuations → final synthesis
timeout: command override → protected repository config → 30 minutes

review.timeout_minutes and --timeout MINUTES share one host-enforced deadline and the unchanged global 100-request allowance. The GitHub-hosted six-hour job ceiling reserves 30 minutes for setup/refresh/cleanup. Host-only serialized token renewal persists encrypted rotation before updating the proxy-only access token. Read-token renewal repeats live OIDC/installation/permission/commit checks. Request expiry and leases follow the chosen timeout; merge intent still expires independently after one hour.

Evidence

  • Before: configuration/parser rejected timeout selection; continuation re-sent complete group evidence and retried a group before scheduling the rest.
    After: deterministic regressions check positive timeout values, precedence, equivalent-command idempotency, request/lease expiry, concurrency, assigned-file coverage, dependency grouping, pending-only continuation, synthesis reserve and fail-closed output.
  • npm run check: 267 passing tests, typecheck, lint and build. Clean source install/check, real workerd/D1, synthetic browser onboarding, pinned model catalog, audit (zero vulnerabilities), Actionlint and Wrangler dry-run passed.
  • Docker image build and all 20 native pinned-Codex scripted-provider inspection/isolation scenarios passed, including four distinct PNGs, continuation, synthesis and compaction. Runtime import testing caught and fixed host-only TypeScript loading before publication.
  • Real isolated ChatGPT acceptance passed: 93-file review completed all six groups and synthesis in 10m45s, finding both seeded tenant and stale-response defects; small clean review completed with --timeout 60. Native COMMENT publication is bound to each exact head. The 93-file fixture has 1,668 changed lines, not the roughly 8,700 in the production report; this does not guarantee every large PR completes. A separate >12,000-line planner regression checks bounded lossless grouping.
  • Coordinated rollout completed via Prepare 0.1.3 and close merge gate for coordinated rollout #60, chore: align CodexBot immutable review source #61 and Restore merge gate after verified 0.1.3 cutover #62. Both maintained caller pins match immutable source 23018028dc656100c1b313a01bf20e7109b8258a; credential-only production OIDC checks passed with inference skipped. Regular release v0.1.3 is deployed with the merge gate restored, browser/hosted-inference flags disabled, and health verified. Test credentials and resources were cleaned up; no KMU AI review was triggered.

Merge Danger

Door: two-way

No database migration. Runner and Worker changes require coordinated immutable source/caller pins after successful isolated acceptance; do not deploy the runner alone.

Blast Radius: review-runtime

Longer operator-selected reviews consume additional Actions/ChatGPT allowance. The reviewer remains network-isolated, read-only and credential-free; incomplete/unverified analysis never approves or merges. Token rotation failure remains fail-closed and may require reconnection after an uncertain provider exchange.

@AppSolves
AppSolves merged commit d4e0dfe into main Nov 16, 2026
4 checks passed
@AppSolves
AppSolves deleted the fix/targeted-review-progress-and-timeouts branch November 16, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant