Skip to content

ci: run PR checks on pull_request so release-please PRs get them - #128

Merged
jonathannorris merged 2 commits into
mainfrom
ci/pr-triggers
Nov 17, 2026
Merged

jonathannorris merged 2 commits into
mainfrom
ci/pr-triggers

Conversation

@jonathannorris

Copy link
Copy Markdown
Member

Summary

  • Unit Tests, Test Examples and Benchmark only ran on push. Release-please pushes its branch with GITHUB_TOKEN, which never starts workflows, so its release PRs were missing required checks. They now run on pull_request, and on push to main.
  • Semantic PR switches from pull_request_target to pull_request. GitHub never starts pull_request_target runs for PRs opened by github-actions[bot], but pull_request runs are created and wait for approval like the other checks.
  • Feature branches no longer run the tests twice (on push and on pull_request).

Related Issues

Follow-up to #124

@jonathannorris
jonathannorris requested a review from a team as a code owner November 17, 2026 19:30
Copilot AI balanced review requested due to automatic review settings November 17, 2026 19:30
@jonathannorris
jonathannorris enabled auto-merge (squash) November 17, 2026 19:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified in the CI trigger changes.

No open issues 🎉

What changed in this PR

This PR updates the Python SDK’s CI triggers, aiming to provide checks for release-please PRs without overlapping feature-branch push and PR runs.

Changes:

  • Unit Tests, Test Examples, and Benchmark now run on pull requests and pushes to main.
  • Semantic PR switches from pull_request_target to pull_request and adds the reopened event.
File Description
.github/​workflows/​unit_test.yml Adds PR-triggered unit tests and limits push runs to main.
.github/​workflows/​test_examples.yml Adds PR-triggered example checks and limits push runs to main.
.github/​workflows/​check-semantic.yml Changes the semantic-title check’s event, adds reopening support, and documents the rationale.
.github/​workflows/​benchmark.yml Adds PR-triggered benchmarks and limits push runs to main.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants