Repository navigation
ci: run PR checks on pull_request so release-please PRs get them - #128
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the CI trigger changes.
No open issues 🎉
What changed in this PR
This PR updates the Python SDK’s CI triggers, aiming to provide checks for release-please PRs without overlapping feature-branch push and PR runs.
Changes:
- Unit Tests, Test Examples, and Benchmark now run on pull requests and pushes to
main. - Semantic PR switches from
pull_request_targettopull_requestand adds thereopenedevent.
| File | Description |
|---|---|
.github/workflows/unit_test.yml |
Adds PR-triggered unit tests and limits push runs to main. |
.github/workflows/test_examples.yml |
Adds PR-triggered example checks and limits push runs to main. |
.github/workflows/check-semantic.yml |
Changes the semantic-title check’s event, adds reopening support, and documents the rationale. |
.github/workflows/benchmark.yml |
Adds PR-triggered benchmarks and limits push runs to main. |
Review effort: Balanced
jonathannorris
force-pushed
the
ci/pr-triggers
branch
from
November 17, 2026 19:34
498dffd to
65f1127
Compare
suthar26
approved these changes
Nov 17, 2026
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
push. Release-please pushes its branch withGITHUB_TOKEN, which never starts workflows, so its release PRs were missing required checks. They now run onpull_request, and onpushtomain.pull_request_targettopull_request. GitHub never startspull_request_targetruns for PRs opened bygithub-actions[bot], butpull_requestruns are created and wait for approval like the other checks.pushand onpull_request).Related Issues
Follow-up to #124