Repository navigation
Warn when SBML events still lack a priority - #614
Open
ChenYueqi2024 wants to merge 2 commits into
Open
ChenYueqi2024 wants to merge 2 commits into
ChenYueqi2024 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #525.
When automatic assignment leaves an SBML event unprioritized, the converter misses the usual case where the event has no priority element. Reuse the converter's existing priority check so it warns for events that still have no priority expression. This helps users diagnose ambiguous ordering when model events coincide with PEtab condition changes.
The regression checks cover multiple unprioritized events and an event that cannot receive an automatic priority because another event already has negative infinite priority. They also verify that events with explicit or automatically assigned priorities produce no missing-priority warning.
Validation on Windows with Python 3.12: the two affected cases fail before the fix. All 70 tests across the converter, assignment-to-experiments, and experiment modules pass afterward, including the COPASI simulation comparison. All applicable pre-commit hooks and
git diff --checkpass.Implemented and validated with OpenAI Codex assistance. Ready for review.