Skip to content

Warn when SBML events still lack a priority - #614

Open
ChenYueqi2024 wants to merge 2 commits into
PEtab-dev:mainfrom
ChenYueqi2024:fix/warn-missing-event-priority-525
Open

ChenYueqi2024 wants to merge 2 commits into
PEtab-dev:mainfrom
ChenYueqi2024:fix/warn-missing-event-priority-525

Conversation

@ChenYueqi2024

Copy link
Copy Markdown

Fixes #525.

When automatic assignment leaves an SBML event unprioritized, the converter misses the usual case where the event has no priority element. Reuse the converter's existing priority check so it warns for events that still have no priority expression. This helps users diagnose ambiguous ordering when model events coincide with PEtab condition changes.

The regression checks cover multiple unprioritized events and an event that cannot receive an automatic priority because another event already has negative infinite priority. They also verify that events with explicit or automatically assigned priorities produce no missing-priority warning.

Validation on Windows with Python 3.12: the two affected cases fail before the fix. All 70 tests across the converter, assignment-to-experiments, and experiment modules pass afterward, including the COPASI simulation comparison. All applicable pre-commit hooks and git diff --check pass.

Implemented and validated with OpenAI Codex assistance. Ready for review.

@ChenYueqi2024
ChenYueqi2024 requested a review from a team as a code owner November 19, 2026 12:30
Copilot AI balanced review requested due to automatic review settings November 19, 2026 12:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExperimentsToSbmlConverter: "no priority set" warning is unreachable

2 participants