Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.d/+warn-unprioritized-events.fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Warn during experiment conversion when an SBML event still lacks a priority,
so users can address ambiguous ordering with PEtab condition changes
([#614](https://github.com/PEtab-dev/libpetab-python/pull/614)).
2 changes: 1 addition & 1 deletion petab/v2/converters.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def _preprocess(self) -> None:

for event in model.getListOfEvents():
# Check for undefined event priorities and warn
if (prio := event.getPriority()) and prio.getMath() is None:
if not self._has_priority(event):
warnings.warn(
f"Event `{event.getId()}` has no priority set. "
"Make sure that this event cannot trigger at the time of "
Expand Down
13 changes: 12 additions & 1 deletion tests/v2/test_converters.py
Original file line number Diff line number Diff line change
Expand Up @@ -347,14 +347,25 @@ def _problem_0030(model_events: str) -> Problem:
("", {PETAB_EVENT: None}),
],
)
def test_auto_event_priority(model_events, expected):
def test_auto_event_priority(model_events, expected, recwarn):
"""Test automatic priority assignment for pre-existing events."""
problem = _problem_0030(model_events)
orig_priorities = _event_priorities(problem.model.sbml_model)

converted = ExperimentsToSbmlConverter(problem).convert()

assert _event_priorities(converted.model.sbml_model) == expected
expected_warnings = {
f"Event `{event_id}` has no priority set."
for event_id in orig_priorities
if expected[event_id] is None
}
actual_warnings = {
str(warning.message).split(" Make sure", 1)[0]
for warning in recwarn
if "has no priority set." in str(warning.message)
}
assert actual_warnings == expected_warnings
# the original problem is not modified
assert _event_priorities(problem.model.sbml_model) == orig_priorities

Expand Down