Repository navigation
feat(datagrid): wrap long values onto several lines in the data grid - #4378
Merged
Merged
Conversation
# Conflicts: # windows/docs/decisions/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
heightOfRowanswered only while wrap is on, heights from a per-row line count measured with Core Text, both panes noted in one call with the first visible row held in place.RowHeightsstore behindRowTop/RowHeightOf/RowAt(Windows decision 0024).GridCellmeasures height for width while wrap is on (Linux decision 0047).Defects fixed along the way:
Pinned tests changed on purpose:
tests/menus.rs: the header menu has 10 actions and the row-number header menu listsgrid.wrap-text.QueryTabTests.ARunSendsTheSelectionOrTheWholeTextWhenNothingIsSelected: the snapshot gainsWrapText = false.Docs: TableProApp/docs#259 (draft).
Windows and Linux shots: the Windows UI test
WrapTextTestswrites185-grid-wrap-textand186-grid-wrap-text-header-menuto the CI screenshot artifact.Test plan
DataGridWordWrapTests,DataGridWrapLayoutTests,DataTabWrapTextTests,SpecialCharacterTextTestsare new; 229 cases over 17 suites pass.RowHeightsTests,WrapTextTestsand the corecell_texttests are new; the solution's 2327 cases pass on macOS.TablePro.DataGrid.Testsand the UI tests run only in CI.data_grid/tests/wrap.rsis new;tablepro3684 cases andtablepro-linux-platform69 cases pass in the dev container.Fixes #4329