Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditorTabDetachUITests.testDraggingATabOutOfTheStripOpensItInItsOwnWindowat its cause, in the app.mouseDraggedthen started anNSDraggingSession, which never sees the release.EditorTabItemViewstarts a session only while the primary button is down. Otherwise the queuedmouseUpsettles the drop at the release point: a strip under it reorders or receives the tab, anywhere else follows the session's tear-off rule.performDragOperationand the late drop share the reorder and receive commits.EditorTabStripView.isPrimaryButtonDownis injectable for tests;dragDidEndreads it too.Test plan
EditorTabLateDragTests: a late drag out of the strip starts no session and tears off at the release point; a tab the policy refuses opens nothing; Escape before the queued release cancels it, and the next late drag is not cancelled; a late drop reorders in its own strip, is received by another strip of the connection, is refused by another connection's; the release point resolves to the strip under it.EditorTabDetachUITestsunchanged: both cases passed on the first attempt in run 44895942030.