Repository navigation
fix: bound sync-window duration parsing to prevent ReDoS - #329
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
==========================================
+ Coverage 11.30% 15.37% +4.07%
==========================================
Files 169 233 +64
Lines 6679 8499 +1820
Branches 2235 2808 +573
==========================================
+ Hits 755 1307 +552
- Misses 5923 7190 +1267
- Partials 1 2 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@keithchong, decided to not not hard code translation because I saw that you had separate PRs for translation. Please let me know if I should revert the last translation commit for the sake of time. |
| const bInvalid = Number.isNaN(bMinutes); | ||
|
|
||
| if (aInvalid && bInvalid) { | ||
| return a.localeCompare(b); |
There was a problem hiding this comment.
If both are NaN, do we really need to compare them?
There was a problem hiding this comment.
Thanks, I will return a 0.
Leave it in |
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
31fc502 to
be407b3
Compare
keithchong
left a comment
There was a problem hiding this comment.
Thanks @aali309 for getting this complete so quickly. LGTM.
see: GITOPS-12037
This PR
Invalid or nill durations
All valid durations
