Skip to content

feat: upgrade Rsbuild, Rslib, and Rstest examples to Solid 2 - #526

Merged
chenjiahan merged 3 commits into
mainfrom
chenjiahan/solid-v2-examples
Nov 18, 2026
Merged

chenjiahan merged 3 commits into
mainfrom
chenjiahan/solid-v2-examples

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Upgrade the four Solid examples in Rsbuild, Rslib, and Rstest to Solid 2 with native JSX compilation, removing the Babel plugin configuration.

Rslib keeps compiled and JSX exports and uses the Solid 2-compatible testing-library RC. The Rstest counter example uses jsdom and flushes batched updates because happy-dom 21.0.4 mishandles numeric zero text nodes.

Validated builds, TypeScript checks, all six tests, library watch builds, and browser interaction/HMR.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T10:39:09.276474Z 7ff861f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan chenjiahan changed the title feat: migrate Solid examples to Solid 2 feat: upgrade Rsbuild, Rslib, and Rstest examples to Solid 2 Nov 18, 2026
@chenjiahan
chenjiahan merged commit 9334692 into main Nov 18, 2026
1 check passed
@chenjiahan
chenjiahan deleted the chenjiahan/solid-v2-examples branch November 18, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant